Re: [RFC][Discussion] Using TidyException new type for tidy extension
| From: | David CARLIER | Date: | Fri, 31 Oct 2025 09:42:48 +0000 |
| Subject: | Re: [RFC][Discussion] Using TidyException new type for tidy extension | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-129020@lists.php.net to get a copy of this message | ||
Hi Tim,
On Wed, 29 Oct 2025 at 13:06, Tim Düsterhus <tim@bastelstu.be> wrote:
> Hi
>
> Am 2025-10-26 18:09, schrieb David CARLIER:
> > https://wiki.php.net/rfc/tidyexception-for-tidy
>
> Thank you for the RFC. I believe moving to Exceptions for error handling
> is the right thing, so I support the RFC in principle.
>
> However the proposal is *very* bare-bones. It would be useful to
> describe which errors can currently be emitted from ext/tidy, so that we
> can discuss a proper Exception hierarchy. In the PR I'm seeing just 3
> locations - are those all of them?
>
Yes.
>
> Naming-wise I wonder if we should go all the way to
>
\Tidy\TidyException (i.e. with a namespace) right away.
>
I would not mind going as far as to introduce a whole namespace if needs
be.
RFC updated.
>
> Best regards
> Tim Düsterhus
>