Re: Examples comparing Block Scoped RAII and Context Managers
| From: | Tim Düsterhus | Date: | Tue, 16 Dec 2025 08:58:05 +0000 |
| Subject: | Re: Examples comparing Block Scoped RAII and Context Managers | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-129617@lists.php.net to get a copy of this message | ||
Hi
Am 2025-12-11 22:45, schrieb Rowan Tommins [IMSoP]:
Attachment: [text/x-diff] 0001-Fix-example-syntax-and-add-stub-file-to-make-IDE-hap.patch
For little fixes like this, it would probably be most efficient if you raise a PR, or mail me a patch, rather then me hunting around for each one.Sorry about that. I don't have my personal GitLab account (that I barely use these days) set up on my work machine (thus a PR wouldn't work) and it didn't occur me to just send a patch file. I've just went across all files once more and fixed the obvious syntax errors that VSC pointed out to me. I've also added a stub file to satisfy my language server from pointing out unknown functions / classes. Patch attached. I didn't fix the db-transaction/application/1c-raii-with-scope-declaration.php comment, since that's not a straight-forward fix. I'll try to work through the rest of your email later, but wanted to get this patch out already. Best regards Tim Düsterhus
Attachment: [text/x-diff] 0001-Fix-example-syntax-and-add-stub-file-to-make-IDE-hap.patch