Re: Check RFC draft

From: Date: Thu, 22 Jan 2026 08:38:25 +0000
Subject: Re: Check RFC draft
References: 1  Groups: php.internals 
Request: Send a blank email to internals+get-129840@lists.php.net to get a copy of this message
Hi Am 2026-01-22 09:01, schrieb Barel:
I just created this RFC draft https://wiki.php.net/rfc/prefix_suffix_functions Given that this is my first RFC I would like to ask if it would be possible for someone to take a quick look to see if the format/overall content structure is correct or if there is anything that needs to be changed before I move it to the discussion process
You carefully followed the suggested template and provided extensive explanation of possible edge cases and also meaningful example use cases. I don't see anything that needs changes structure-wise or anything important missing. The formatting in “Edge cases and potential gotchas” is a little broken, instead of the bold bullet points it probably makes sense to add further sub-headings. One note to the implementation: I believe the _ensure and _remove() functions should be “haystack first“ for consistency (i.e. first the target string, then the prefix/suffix). Best regards Tim Düsterhus

« previous php.internals (#129840) next »