Re: [RFC] DocComments For Function Parameters
| From: | Christian Schneider | Date: | Mon, 23 Feb 2026 17:32:29 +0000 |
| Subject: | Re: [RFC] DocComments For Function Parameters | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-130138@lists.php.net to get a copy of this message | ||
Am 22.02.2026 um 18:52 schrieb Tim Düsterhus <tim@bastelstu.be>:
> - Please add a link to the ML discussion to the “References” section:
> https://news-web.php.net/php.internals/130121
>
> - The ABI change is irrelevant: Extensions have to be recompiled for every PHP branch and new
> features may not ship with 3rd-digit versions anyways. Mentioning this is thus misleading at best
> (affecting “Backwards incompatible changes”, “Proposed PHP version”, and “RFC Impact”).
>
> - In fact, there is not even an ABI change, because the new field is added at the end of the
> struct.
>
> - Within the “Ecosystem” impact, you should probably mention that this might require
> adjustments to code style / formatting guidelines and autoformatters - or at the very least a
> decision needs to be made there.
Thanks for this feedback.
I changed the RFC accordingly and also added an implementation PR and a test and I would consider it
ready.
RFC: https://wiki.php.net/rfc/parameter-doccomments
PR: https://github.com/php/php-src/pull/21279
Regards,
- Chris