Re: [PATCH] add --with-libdir flag (was Re: [PHP-DEV] ./configure, PHP, SuSE and the AMD64)

On Mon, 27 Sep 2004, Joe Orton wrote: > On Mon, Sep 27, 2004 at 10:13:04AM +0200, Derick Rethans wrote: > > On Sat, 25 Sep 2004, Robert Silva wrote: > > > Again, if you look at the Suse php config patch it will show you what you > > > need to change to get it up and running. > > > > > > http://www.bobsilva.com/php-4.3.3-lib64.diff > > > > I think this patch is the way to go for this, but it won't address > > issues when you mix both 64bit and 32bit libraries as this one simply > > requires you to have everything in either 32bit or 64bit. So we can't > > really commit it. > > I don't know what you mean by that. You can't link both 32-bit or 64-bit > libraries into one program, that doesn't work, of course. Ok, but having them in /lib and /lib32 at the same time does I guess. (though it still doesn't make sense to do so, and you can always symlink this). > I have a patch based loosely on the SuSE patch which adds a > --with-libdir flag, which defines PHP_LIBDIR and adjusts > ext/*/config*.m4 to use that rather than assuming libraries are in > /path/foo/lib/lib*. > > I've attached two patches: the first showing just the changes neeeded to > configure.in and acinclude.m4, and the second including all the gory > details to ext/*. > > Any objections to committing this to HEAD? Tested on RHEL3/x86_64 using > --with-libdir=lib64 (where it builds rather than dying horribly), and on > Fedora Core 3 test 2/i686 (where it still builds). It looks okay to me, but I'd like to hear some other comments too :) Derick