Re: DocComments for internal functions
| From: | Christian Schneider | Date: | Fri, 10 Apr 2026 21:47:15 +0000 |
| Subject: | Re: DocComments for internal functions | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-130604@lists.php.net to get a copy of this message | ||
Am 10.04.2026 um 17:40 schrieb Derick Rethans <derick@php.net>:
> On 10 April 2026 15:21:34 BST, Christian Schneider <cschneid@cschneid.com> wrote:
>> Am 10.04.2026 um 12:54 schrieb Gina P. Banyard <internals@gpb.moe>:
>>> On Thursday, 9 April 2026 at 14:33, Christian Schneider <cschneid@cschneid.com>
>>> wrote:
>>>> The implementation can be examined at
>>>>
>>>> https://github.com/php/php-src/compare/master...chschneider:php-src:internal-functions-doccomments
>>>
>>> I am not *fully* convinced that we should add DocComments for internal
>>> parameters/functions/classes/constants, as this feels like a lot of complexity.
>>
>> What kind of complexity are you thinking about? Code-wise? Integration into the build
>> process?
>
> I'm wondering how much this does to increase the size of the PHP compiled binaries.
On my machine it adds about 2M (7%) as the sapi/cli/php binary increases from ~28M to ~30M for a
build with default ./configure and
CFLAGS="-O3 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64"
I would assume this is mostly in a read-only data section and hence shareable between processes.
- Chris