Re: [RFC] Deprecate Metaphone Function

Hi, >I believe the deprecation of individual functions is better suited for  >the bulk deprecation RFC at  >https://wiki.php.net/rfc/deprecations_php_8_6, because there is often  >not much to discuss and having individual RFCs for everything just adds  >overhead. I am just aware of this RFC this morning when Gina told me about it.  Thankfully the RFC is still yet to move to voting process so it will be  more effective to withdraw this separate RFC and add a new entry in https://wiki.php.net/rfc/deprecations_php_8_6 >That said: I don't think there is a strong argument in favor of  >deprecating metaphone. Yes, the algorithm is dated. Yes, we likely would  >not add this kind of functionality to the stdlib nowadays. But it's not  >*actively* harmful as far as I can tell.  >It does exactly what the name  AFAIK It doesn't. The metaphone algorithm is "dated" which means it is way less accurate than other existing algorithms. That is, I don't think users should be recommend to use it anymore. The core maintains the least accurate version of metaphone. >implies and it's not a security-sensitive function where we would want  >to steer users towards safer options. Of course. However as I've said above it is not accurate. In other words, it don't work well in today's cases comparing to user-land implementations. Thanks, Weilin Du