Re: Re: realpath patch

At 11:24 AM 10/1/2004 -0700, Sara Golemon wrote:

I'd like to commit the realpath() patch I sent to the list for review a week or so ago. Unless there are any objections I'll commit it (to HEAD) in 1-2 days. This will give it some more exposure and will have more people testing it. Somehow the patch is no longer in my news spool, so rather then looking at the source I'll just ask: Are all uses of VCWD_REALPATH() effected by this? If so it could provide a means to bypass basedir checks (and possibly certain parts of safe_mode). A scripter on a shared host could create a symlink, get the cache to catch it, then change the symlink to point to a different (ordinarily restricted) location, then do normal file ops letting the basedir check believe that the script is accessing a valid location. Can we roll in a VCWD_REALPATH_NO_CACHE() macro to avoid problems like this?

http://snaps.php.net/~andi/realpath_cache2.diff Hmm, you are quite a hacker :) I think you might be on to something. Can you take a look and see what changes we'd require? Andi