Re: [php-src] PR #20903: GH-10497 (const obj->prop write) - language change notes
| From: | Khaled Alam | Date: | Sun, 21 Jun 2026 18:28:12 +0000 |
| Subject: | Re: [php-src] PR #20903: GH-10497 (const obj->prop write) - language change notes | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-131440@lists.php.net to get a copy of this message | ||
Hi all,
Reviving this thread. The v0.2 RFC
<https://wiki.php.net/rfc/const_object_property_write>
(object property
writes on constants only;
array/dim writes removed) addressed Tim's concerns, and the 14-day cooldown
has long passed.
Unless there are further objections, I intend to open voting on Monday, 29
June 2026. 2/3 majority,
targets PHP 8.6, two-week vote.
RFC: https://wiki.php.net/rfc/const_object_property_write
PR: https://github.com/php/php-src/pull/20903
Best regards,
__
*Khaled Alam*
On Sat, Apr 11, 2026 at 3:14 PM Khaled Alam <khaledalam.net@gmail.com>
wrote:
> Hi Tim,
>
> On Apr 9, 2026, 10:39 AM, Tim Düsterhus <tim@bastelstu.be> wrote:
> > With regard to the RFC policy, I just added the necessary “Abstain”
> > option to the vote.
> >
> > I'm also noting some rendering issues in the RFC, particularly in the
> > Proposal section, where the “bullet point list” does not render
> > properly, due to the line-breaks in the markup. I'm also seeing that you
> > try to use the markdown syntax for inline code. That doesn't work in the
> > Wiki, since it doesn't speak markdown. When showcasing PHP code, I
> > recommend using <php>isset()</php> tags (<php> XML tag). For
> > non-PHP-Code ''BP_VAR_FUNC_ARG'' (two single-quotes works). You might
> > want to clean-up both of these, it will make the RFC look much nicer and
> > more approachable.
> >
> > Please note that your RFC update is considered a major change, so it
> > needs 14 days of “cooldown” for discussion, before the RFC can go to
> > vote.
>
> Thanks for the feedback, I just fixed the RFC
> <https://wiki.php.net/rfc/const_object_property_write>
> rendering issues.
>
> Best regards,
> __
>
> *Khaled Alam*
>
>
> On Thu, Apr 9, 2026 at 10:39 AM Tim Düsterhus <tim@bastelstu..be> wrote:
>
>> Hi
>>
>> Am 2026-04-04 02:52, schrieb Khaled Alam:
>> > I'd like to bring attention back to this RFC, which has been updated to
>> > v0.2 based on prior feedback:
>> >
>> > https://wiki.php.net/rfc/const_object_property_write
>>
>> Thank you. The updated RFC makes sense to me and with the removal of the
>>
FOO[123] = 'bar'; support I don't have any
>> further technical concerns.
>>
>> With regard to the RFC policy, I just added the necessary “Abstain”
>> option to the vote.
>>
>> I'm also noting some rendering issues in the RFC, particularly in the
>> Proposal section, where the “bullet point list” does not render
>> properly, due to the line-breaks in the markup. I'm also seeing that you
>> try to use the markdown syntax for inline code. That doesn't work in the
>> Wiki, since it doesn't speak markdown. When showcasing PHP code, I
>> recommend using <php>isset()</php> tags (<php> XML tag). For
>> non-PHP-Code ''BP_VAR_FUNC_ARG'' (two single-quotes works). You might
>> want to clean-up both of these, it will make the RFC look much nicer and
>> more approachable.
>>
>> Please note that your RFC update is considered a major change, so it
>> needs 14 days of “cooldown” for discussion, before the RFC can go to
>> vote.
>>
>> Best regards
>> Tim Düsterhus
>>
>