Re: Fwd: [PATCH] added: openssl_csr_subject()
| From: | Wez Furlong | Date: | Fri, 08 Oct 2004 20:22:26 +0000 |
| Subject: | Re: Fwd: [PATCH] added: openssl_csr_subject() | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13246@lists.php.net to get a copy of this message | ||
Two or three comments:
- You leak the dynamically allocated buffer returned by X509_NAME_oneline()
- X509_NAME_oneline() man page says that its use is discouraged in
favour of smarter functions. Is there a possibility that someone will
need that functionality?
- if you can solve/answer both of the above, please post a link to the patch
Thanks :)
--Wez.
On Fri, 08 Oct 2004 15:48:34 -0400, Greg MacLellan
<greg@gregmaclellan.com> wrote:
> I apologize - it helps when I actually attach the patch.