Re: [RFC] Deprecate Invalid Filter Options
| From: | Muhammed Arshid KV | Date: | Sun, 04 Oct 2026 08:38:39 +0000 |
| Subject: | Re: [RFC] Deprecate Invalid Filter Options | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-132780@lists.php.net to get a copy of this message | ||
On Sun, 4 Oct 2026 at 01:52, Calvin Buckley <calvin@cmpct.info> wrote:
>Looks reasonable at first glance. My additional suggestions for
>follow-on RFCs would be:
>
>- The filter types could be turned into an enum. Would be a pretty
> simple RFC.
>- Get rid of SAPI-side input filters for the superglobals; they
> complicate code that works with them a bit. The INI option that
> controls them is already deprecated, so, an RFC to get rid of them
> completely?
>
>I do think ext/filter is kind of weird in that the API is very pre-OO
>and has a bunch of hardcoded filters and assumptions on how people used
>the superglobals, but if we have it, it's still worth cleaning up.
You're correct. I agree that the filter types would be better handled as a
separate, focused RFC for enums.
I'll close this RFC and pursue the enum proposal separately. I have already
opened a PR for the implementation:
https://github.com/php/php-src/pull/24111
Thanks for the suggestion!