Re: [RFC] openssl_get_channel_binding
| From: | Sjoerd Langkemper | Date: | Tue, 03 Nov 2026 11:37:24 +0000 |
| Subject: | Re: [RFC] openssl_get_channel_binding | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-132993@lists.php.net to get a copy of this message | ||
On Thu, Oct 29, 2026, at 21:18, Sjoerd Langkemper wrote:
> Thank you for the thorough review.
>
> On Wed, Oct 28, 2026, at 15:18, Tim Düsterhus wrote:
>> An operation that is not applicable sounds like an Exception to me.
> I can see the appeal of throwing a specific exception (e.g. UnsupportedChannelBinding extends
> OpensslExtension). Then if the function returns something the caller knows it is a valid channel
> binding value.
I changed the RFC to reflect this. openssl_get_channel_binding can no longer return null, but it can
throw a (newly introduced) UnsupportedChannelBindingException.
Regards,
Sjoerd