Re: [RFC] Io\Terminal

From: Date: Fri, 20 Nov 2026 08:23:40 +0000
Subject: Re: [RFC] Io\Terminal
References: 1 2 3  Groups: php.internals 
Request: Send a blank email to internals+get-133135@lists.php.net to get a copy of this message
Hi On 2026-11-20 05:53, Pratik Bhujel wrote:
There has been no further feedback since the v0.6 update, so this is my intent to vote on the Io\Terminal RFC. […] If you have any remaining concerns or questions, please let me know before then.
I have given the RFC another read now and besides my previous reply to the existing points, I have also noticed: 1. Dimensions::$cols is an abbreviation which according to naming policy (https://github.com/php/policies/blob/main/coding-standards-and-naming.rst#acronyms) should be avoided. I think spelling out $columns is fine from a DX perspective. 2. Spelling out whether or not the Key enum is expected to grow in the future and how folks are supposed to handle it correctly. This somewhat ties into what Frode said about input processing: Say I'm manually handling a key sequence right now, e.g. "\x1b[1;5D" and then in a later version, Key::CtrlLeft is added to the enum, then there would effectively be two related breaking changes: - My check for "\x1b[1;5D" would no longer match. - A Key::CtrlLeft enum case might arrive that my code is not prepared to handle. Best regards Tim Düsterhus

« previous php.internals (#133135) next »