Re: cvs: php4 /bundle/libxml/include/libxml xmlversion.h
| From: | Christian Stocker | Date: | Wed, 07 May 2003 12:49:51 +0000 |
| Subject: | Re: cvs: php4 /bundle/libxml/include/libxml xmlversion.h | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-1344@lists.php.net to get a copy of this message | ||
On Wed, 2003-05-07 at 14:26, Moriyoshi Koizumi wrote:
> moriyoshi Wed May 7 08:26:58 2003 EDT
>
> Modified files:
> /php4/bundle/libxml/include/libxml xmlversion.h
> Log:
> Fixed build with iconv disabled
>
>
> Index: php4/bundle/libxml/include/libxml/xmlversion.h
> diff -u php4/bundle/libxml/include/libxml/xmlversion.h:1.1
> php4/bundle/libxml/include/libxml/xmlversion.h:1.2
> --- php4/bundle/libxml/include/libxml/xmlversion.h:1.1 Tue May 6 15:38:49 2003
> +++ php4/bundle/libxml/include/libxml/xmlversion.h Wed May 7 08:26:58 2003
> @@ -167,7 +167,7 @@
> *
> * Whether iconv support is available
> */
> -#if 1
> +#if 0
> #define LIBXML_ICONV_ENABLED
> #endif
There we go.... If we start to patch libxml in the bundle directory, we
will end up in upgrade hell... libxml2 has a new release almost every
month, who's going to integrate our changes with the new release then?
And BTW, it looks like only 2.4.30 was used for the commit, while
already 2.5.7 with much better Schema support and other goodies is out.
chregu