Re: [PATCH] Bug #30743 - proc_close() causes a handle leak
| From: | Derick Rethans | Date: | Wed, 10 Nov 2004 16:06:56 +0000 |
| Subject: | Re: [PATCH] Bug #30743 - proc_close() causes a handle leak | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-13809@lists.php.net to get a copy of this message | ||
On Wed, 10 Nov 2004, ilya77@gmail.com wrote:
> Hi Guys,
>
> PHP_FUNCTION(proc_close) doesn't have a call to
> CloseHandle(proc->child), to close the process handle.
> This is causing a handle leak on Windows, and eventually brings the
> whole OS to it's knees.
>
> Here's the fixed code snippet (there's a DIFF at the end of the file):
Can you please post a unified diff without any whitespace changes (and
put it online and provide a link, as gmail mangles files it seems).
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org