Bug fix for #28817 - different behaviour in HEAD and 5_0
| From: | Georg Richter | Date: | Fri, 03 Dec 2004 16:14:34 +0000 |
| Subject: | Bug fix for #28817 - different behaviour in HEAD and 5_0 | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-13996@lists.php.net to get a copy of this message | ||
Hi,
the following patch solves bug #28817 in HEAD.
However it doesn't work in 5_0 branch. In 5_0 I have to set
retval->refcount to 1 to get it work - any ideas what's going wrong ?!
Same behaviour in mysqli (which has a similiar property handling).
/Georg
Patch:
diff -u -r1.64 php_dom.c
--- php_dom.c 7 Oct 2004 11:40:20 -0000 1.64
+++ php_dom.c 3 Dec 2004 13:49:25 -0000
@@ -235,6 +235,7 @@
} else {
std_hnd = zend_get_std_object_handlers();
retval = std_hnd->read_property(object, member, type
TSRMLS_CC);
+ retval->refcount = 0;
}
if (member == &tmp_member) {