Re: Re: broken fix?
| From: | Wez Furlong | Date: | Thu, 30 Dec 2004 03:51:14 +0000 |
| Subject: | Re: Re: broken fix? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-14236@lists.php.net to get a copy of this message | ||
This bug is critical for 4.3.11, and has repercussions for any
extension with overloaded objects, not just COM.
--Wez.
On Sat, 25 Dec 2004 15:48:26 +0200 (IST), Stanislav Malyshev
<stas@zend.com> wrote:
> Did you look into my latest patch and try with it?
The tip of the 4.3 branch is still broken; and I don't see any changes
in CVS either before or after the commit I mentioned--did you forget
to commit something?
WF>>http://viewcvs.php.net/viewcvs.cgi/Zend/Attic/zend_execute.c.diff?r1=1.316.2.41&r2=1.316.2.42&hideattic=0
> WF>>
> WF>>fix overloaded calls not returning result, e.g.:
> WF>><? new Java('foo'); ?>
> WF>>
> WF>>is to blame.
> WF>>
> WF>>If you counter-act the unlock in the COM call handler (setting is_ref
> WF>>and bumping the refcount), things work "fine". This is a hack, so I'm
> WF>>hoping that you engine gurus will divine the correct fix.
>
> I think the is_ref thing is the key, see above. I'll check with your
> example on Sunday.