Re: Re: xml_parser_create patch

On Fri, May 09, 2003 at 05:05:12PM +0200, nicos@php.net wrote: > Okay I agree that using UT and not UTF-8 is bad, but isn't it a BC break if > people were using that to get UTF-8? If they were, they would have an error in their script before _and_ now with the fix, IMHO. Breaking BC by fixing a bug makes sense to me. So would "ISO-" mean ISO-8859-1 and not another ISO character set (which there are many of). -- Adam > Regards. > M.CHAILLAN Nicolas > nicos@php.net > www.WorldAKT.com Hébergement de sites internets. > ----- Original Message ----- > From: "Adam Dickmeiss" <adam@indexdata.dk> > To: "Moriyoshi Koizumi" <moriyoshi@at.wakwak.com> > Cc: "Derick Rethans" <derick@php.net>; "Adam Dickmeiss" > <adam@indexdata.dk>; > <nicos@php.net>; <internals@lists.php.net> > Sent: Friday, May 09, 2003 4:11 PM > Subject: Re: [PHP-DEV] Re: xml_parser_create patch > > > > Hi, > > > > here is another patch that recognizes "" as "proper > > XML decoding". I also discovered incorrect string comparison > > of other encodings in the xml_parser_create handler .. > > Basically, a call such as > > xml_parser_create("UT"); would be treated as > > xml_parser_create("UTF-8"); > > ... which can't be right. It should trigger an error. > > > > The patch only includes xml_parser_create not _ns variant. > > You people with karma can figure that out. > > > > I have a character encoding handler for Expat that allows > > expat to use conversion for all encodings it doesn't know. > > I used it in another piece of software but it could be > > easily modified for ext/xml. Now, since Expat is fading > > away that might not be of interest. > > > > -- Adam > > > > On Thu, May 08, 2003 at 09:19:08PM +0900, Moriyoshi Koizumi wrote: > > > Derick Rethans <derick@php.net> wrote: > > > > > > > On Wed, 7 May 2003, Adam Dickmeiss wrote: > > > > > > > > > On Wed, May 07, 2003 at 12:33:20PM +0200, nicos@php.net wrote: > > > > > > -1 for the patch if it doesn't have a default value for the > encoding. > > > > > > > > > > > > We don't want to break BC again. > > > > > I respect that. I hope Streling does too with a new layer on > > > > > top .. > > > > > > > > > > How about letting the empty string mean : Auto encoding?? > > > > > > > > > > xml_parser_create(""); // any decoding! (pass 0 to Expat) > > > > > > > > too much magic. > > > > > > I don't think so, as such a convension already exists in the > > > third parameter of htmlentities(). Are you going to come up with any > other > > > solution? > > > > > > Moriyoshi > > > > > > > Derick > > > > > > > > -- > > > > "my other box is your windows > PC" > > > > > ------------------------------------------------------------------------- > > > > Derick Rethans > http://derickrethans.nl/ > > > > PHP Magazine - PHP Magazine for Professionals > http://php-mag.net/ > > > > > ------------------------------------------------------------------------- > > > > > > > > -- > > > > PHP Internals - PHP Runtime Development Mailing List > > > > To unsubscribe, visit: ¨"¬/x`udè³Ò > > > > ~W2http://www.php.net/unsub.php > > > > > > > > -- > > Adam Dickmeiss mailto:adam@indexdata.dk > > http://www.indexdata.dk > > Index Data T: +45 33410100 Mob.: 212 212 66 > > -- Adam Dickmeiss mailto:adam@indexdata.dk http://www.indexdata.dk Index Data T: +45 33410100 Mob.: 212 212 66