Re: Re: #31098 [Csd]: isset false positive

Looking into it. I agree that we shouldn't break BC. At 05:05 AM 1/13/2005 +0900, Moriyoshi Koizumi wrote:

Hi Dmitry, On 2005/01/12, at 18:28, dmitry@php.net wrote:

patch for HEAD is incorrect. You must not edit zend_vm_execute.h directly. You must edit zend_vm_def.h and then generate zend_vm_execute.h with zend_vm_gen.php. See README.ZEND_VM for more details.

Excuse me for my ignorance & thank you for the fix.

Also isset($str['str']) returned true, that is wrong from my point of view.

I don't quite agree with you. Indeed it's semantically wrong, yet I think we leave it to behave as in ZE1, in terms of backwards compatibility.

I modified the patch to return false and notification in zend_fetch_dimension_address().

Although I had the same idea to warn incorrect usage of dimension operators, I didn't for the same reason as above. Regards, Moriyoshi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php