Reversion of patch for bug #31398

From: Date: Sun, 23 Jan 2005 22:04:31 +0000
Subject: Reversion of patch for bug #31398
Groups: php.internals 
Request: Send a blank email to internals+get-14419@lists.php.net to get a copy of this message
Ilia, While your opinion that we shouldn't count on the "filename" attribute in multiparted queries is quite to the point, your patch totally disregards the old behaviour. We must neither use php_basename() for pathes of a spec different from that defined by the platform which is determined in compile time. That most likely leads to inconsistent behaviour between platforms. In addition, you had removed the portion Rui added in the past that allowed multibyte-encoded filenames to get parsed properly without any notice. Actually the function in question doesn't work at all with such filenames at this momemnt. Due to those issues, I'm going to revert your patch and recommit less radical one. Regards, Moriyoshi

« previous php.internals (#14419) next »