Re: dl() shutdown bug fix
| From: | Zeev Suraski | Date: | Sun, 06 Mar 2005 21:58:12 +0000 |
| Subject: | Re: dl() shutdown bug fix | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15292@lists.php.net to get a copy of this message | ||
The patch looks good. The only thing I'd add is getting rid of the code that became redundant, for clarity (the switch() is not needed in module_registry_cleanup(), and the switch() in module_registry_unload_temp() can be an if()). Did you intend to also commit it to the 5.0 branch or only 5.1? The reason I'm asking is that changing the shutdown order almost always bundles one surprise or another, even though I'm pretty certain it should be pretty safe.
Zeev
At 10:23 06/03/2005, Wez Furlong wrote:
It is/was attached to the mail I sent out; maybe gmail isn't so smart with text attachments. I've attached it to this mail, so you should get it this time. --Wez. On Sun, 06 Mar 2005 08:41:53 +0200, Zeev Suraski <zeev@zend.com> wrote: At 08:18 06/03/2005, Wez Furlong wrote:Any objections to me applying this fix for the unload-module-before-calling-object-dtors bug that I periodically whine about?Is the diff available anywhere? Zeev