Re: Problem with fix for bug #31672

From: Date: Mon, 07 Mar 2005 15:39:42 +0000
Subject: Re: Problem with fix for bug #31672
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-15299@lists.php.net to get a copy of this message
I very much agree with this. It's very common to output JavaScript via PHP, and that also uses the <script></script> tags...so... Ilia Alshanetsky wrote:
Good point, +1 for revert. Ilia Zeev Suraski wrote:
Guys, I'd like to revert the fix for bug #31672 ("</script> is not considered closing tag if preceded by one-line comment"). While theoretically correct, I'd rather resolve it by fixing the docs. The reason is simple - unlike ?> and %>, the string "</script>" is very much likely to appear inside one line comments: // print "<script>foo</script>"; That suddenly fails. That's probably the reason we didn't implement it in the first place. Any objections to reverting this fix? Zeev


« previous php.internals (#15299) next »