Re: zend_stream_fixup
| From: | Wez Furlong | Date: | Wed, 09 Mar 2005 16:14:22 +0000 |
| Subject: | Re: zend_stream_fixup | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15328@lists.php.net to get a copy of this message | ||
Yes, you missed that a stream can be any stream from PHP land.
Which code in the engine does more than read/close?
--Wez.
On Wed, 9 Mar 2005 18:00:11 +0200 (IST), Stanislav Malyshev
<stas@zend.com> wrote:
> WF>>You can't rely on stat working.
>
> Why not? What's so special in stat that it can not work on file handle?
>
> And why this STREAM type at all - if the only places it is used is where
> you have switch on type anyway or in zend_stream.c where you could have
> the switch as well? What did you achive by this but breaking all code that
> used file_handle for more that read/close? So far I see that by using
> fixup and converting all FPs to STREAMs you saved one if in
> zend_stream_read/zend_stream_getc and that's it. Is there anything I miss?