Re: cvs: php-src / NEWS /ext/pcre php_pcre.c php_pcre.h /main SAPI.c /win32 sendmail.c
| From: | Andrey Hristov | Date: | Sat, 19 Mar 2005 08:48:57 +0000 |
| Subject: | Re: cvs: php-src / NEWS /ext/pcre php_pcre.c php_pcre.h /main SAPI.c /win32 sendmail.c | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15502@lists.php.net to get a copy of this message | ||
Hi Andrei,
I think it is hard to distinguisn between a NULL (I don't want this function
to count) and NULL (well, my variable is not initialized but this is the PHP
way of coding).
Do you have an idea?
Andrey
Andrei Zmievski wrote:
I guess it's fine. I would make sure, though, that you can pass NULL for that parameter safely, in case we add another one in the future and you don't need to get the replacement count. On Tue, 15 Mar 2005, Andrey Hristov wrote:Hi Andrei, do you have anything against that change? Cheers, Andrey Andrei Zmievski wrote:- AndreiUh, would be nice to check with me before making this patch..