Re: Re[2]: [PHP-DEV] Fix for 30818, 28839, 32229, 30513
| From: | Kamesh Jayachandran | Date: | Mon, 21 Mar 2005 06:52:10 +0000 |
| Subject: | Re: Re[2]: [PHP-DEV] Fix for 30818, 28839, 32229, 30513 | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-15517@lists.php.net to get a copy of this message | ||
Hi Andi,
I could not see this change in CVS both in 5_0_4-dev tree and HEAD.
Can someone apply my patch?
With regards
Kamesh Jayachandran
On Fri, 18 Mar 2005 13:56:25 -0800, "Andi Gutmans" <andi@zend.com> said:
> Yeah it might make sense to move that to a function. But for some reason
> I
> already see that zend_execute_API.c contains this code in HEAD. Did
> someone
> apply and I missed the commit msg?
>
> Kamesh, can you please verify if it exists in your source tree?
> Good catch btw.
>
> Andi
>
> At 01:46 PM 3/18/2005 +0200, val khokhlov wrote:
> >Hello Kamesh,
> >
> >Friday, March 18, 2005, 1:15:53 PM, you wrote:
> >
> >KJ> Yes I got this fix from pass_two only. It duplicates pass_two especially
> >KJ> the while loop.
> > you see, i also use this part of pass_two() code in my ext. maybe,
> >it'd be a good idea to find one place for this jump addr calculation, so it
> >won't be duplicated? (although, it's likely a question to zend developers)
> >
> >
> >--
> >Best regards,
> > val mailto:val@vk.kiev.ua
> >
> >--
> >PHP Internals - PHP Runtime Development Mailing List
> >To unsubscribe, visit: http://www.php.net/unsub.php
>