Re: Re: cvs: php-src /main php_variables.c

From:	Jani Taskinen	Date:	Sun, 24 Apr 2005 12:45:52 +0000
Subject:	Re: Re: cvs: php-src /main php_variables.c
References:	1 2 3 4 5 6	Groups:	php.internals
Request:	Send a blank email to internals+get-16067@lists.php.net to get a copy of this message

On Sun, 24 Apr 2005, Stefan Esser wrote:

Forgive me my ignorance, but I do not see any handling of " chars.
    And there wasn't such before I added the , as acceptable separator.

^^ I hate when I have to repeat myself, so read the above line again..

Yes because PHP spoke cookie version 0 before your patch. Now it speaks neither version 0 nor version 1 but your own version.

    ..and again..the only change I did was adding , (comma) as the 2nd
    possible separator that might be used by the 2 other cookie specs
    there are for cookies:

      Netscape spec uses only ; but RFCs 2109 and 2965 may use , or ;

    And please tell me how could I "break" anything that was "broken"
    already? As you can of course send this header to ANY PHP version:

      GET / http/1.0
      Cookie: foobar="foo;bar"

    And guess what?! It "works"!
    So do not try to accuse ME for breaking anything that was already broken!!!

    --Jani