Re: Patch for php_error_cb
| From: | Blake Matheny | Date: | Tue, 17 May 2005 14:22:04 +0000 |
| Subject: | Re: Patch for php_error_cb | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-16267@lists.php.net to get a copy of this message | ||
After George's comments, I think I'll just write up an extension and throw it out there. I can still support a script:,file:,socket:,sql: convention for naming and meet all of my requirements. Thanks for the feedback.
-Blake
Wez Furlong wrote:
On 5/17/05, Blake Matheny <bmatheny@3gupload.com> wrote:-- Blake Matheny 3GUpload.com, Inc. Director of Technology 317-472-4962 (W) 317-201-2840 (C) bmatheny@3gupload.com- No need to add an extension every time you upgrade PHPBut you still need to write a custom shared library, so this is not such a great point.- No additional patching (which an extension essentially requires)But you still need to write a custom shared library.- Only adds a couple of extra operations (no performance hit) - Backwards compatible with existing php.iniI don't think those two points are relevant.- Possibility for other prefixes (script:,file:,socket:,etc)This is the only plus point in your argument, but you should consider that we already have a mechanism for logging to files, and no one has asked to be able to log to anything else for quite some time. I think you really need to do some convincing to get the patch in, and I don't see many benefits to the majority of PHP users with the patch as it stands now. --Wez.