Re: PHP 4.4 branch

At 19:38 07.06.2005, Derick Rethans wrote: >On Mon, 6 Jun 2005, Derick Rethans wrote: > > > If you have any issues that you really want to get fixed in PHP 4.4, > > please reply to this email (on the internals@ list). > >If there is nothing, I'd like to start releasing RC1 on Monday. > >regards, >Derick Only one thing: after you reverted my patch (because of my error with the man pages - i'm sorry) the installation of manpages in 4.4 does not work because the variable $(man_PAGES) is not defined in Makefile.frag (it never worked). I also removed the $(bin_src_SCRIPTS) part like in 5.0 and HEAD because the solaris /bin/sh does not like empty lists in for-loops. If there is no problem this time I will apply this patch. ----- Uwe Schindler thetaphi@php.net - http://www.php.net NSAPI SAPI developer Bremen, Germany

Index: scripts/Makefile.frag =================================================================== RCS file: /repository/php-src/scripts/Makefile.frag,v retrieving revision 1.1.2.11.2.3 diff -u -r1.1.2.11.2.3 Makefile.frag --- scripts/Makefile.frag 7 Jun 2005 21:57:13 -0000 1.1.2.11.2.3 +++ scripts/Makefile.frag 8 Jun 2005 07:59:47 -0000 @@ -21,7 +21,7 @@ config.sub bin_SCRIPTS = phpize php-config -bin_src_SCRIPTS = +man_PAGES = phpize.1 php-config.1 install-build: @echo "Installing build environment: $(INSTALL_ROOT)$(phpbuilddir)/" @@ -63,10 +63,6 @@ echo " program: $(program_prefix)$$prog$(program_suffix)"; \ $(INSTALL) -m 755 $(builddir)/$$prog $(INSTALL_ROOT)$(bindir)/$(program_prefix)$$prog$(program_suffix); \ done - @for prog in $(bin_src_SCRIPTS); do \ - echo " program: $(program_prefix)$$prog$(program_suffix)"; \ - $(INSTALL) -m 755 $(top_srcdir)/scripts/$$prog $(INSTALL_ROOT)$(bindir)/$(program_prefix)$$prog$(program_suffix); \ - done @echo "Installing man pages: $(INSTALL_ROOT)$(mandir)/man1/" @$(mkinstalldirs) $(INSTALL_ROOT)$(mandir)/man1 @for page in $(man_PAGES); do \