Re: Re: RFC: internal class' static properties

Marcus Boerger schrieb: > regarding static props the solution is to define another hash table > in the class_entry that holdes the initial values for the static > variables. During minit these would be copied to the used hash table, > done. But even though the solution is pretty easy i do not know if we > really want to support that. We have default properties and all that > stuff already. I attached a patch, which fixes the static property issue for me, though I didn't test as a webserver module yet. > Can't we simply check if default values for static > properties wouldn't do the job and if there is something missing in > that? Huh? I even think that zend_std_get_static_property() is not enough... This forces you to have real zvals for your static properties. Maybe a minor issue (but still an issue :) > class consts should be easy and we two times had a patch for that. > And i definitively ask to support that since otherwise we flood our > namespace, see pdo, spl and the amount of defines there. With a peep > to pecl i see tons of more consts (especially in http). The patch also contains API for class constants, tough valgrind reports some odd errors about the constants_table (among "some" others...) Anyway, I'd be glad if the patch could be reviewed, fixed (as it's most probably not totally accurate) and -even partially- applied. Thanks, Michael