RE: [PHP-DEV] Re: Constants and static methods for internal classes

The patch had a serious bug that corrupts memory on static property update. New patch fixes the bug and adds utility functions. Thanks. Dmitry. > -----Original Message----- > From: Andi Gutmans [mailto:andi@zend.com] > Sent: Tuesday, August 30, 2005 10:57 PM > To: Zeev Suraski; Dmitry Stogov > Cc: 'Michael Wallner'; internals@lists.php.net > Subject: RE: [PHP-DEV] Re: Constants and static methods for > internal classes > > > Okay so if we're going RC2, then I think we can also MFH instanceof > (which is a tiny patch). > > Andi > > At 11:51 AM 8/30/2005, Zeev Suraski wrote: > >I think the patch is fine. We should probably have RC2 for PHP 5.1 > >anyway, so I don't see a problem putting it into the 5.1 tree (it > >does fix a bug and it does break binary compatibility). > > > >Zeev > > > >At 16:37 30/08/2005, Dmitry Stogov wrote: > >>OK. Let me know if you will find any problems with patch. > >> > >>I am not sure that we will aplly this patch to 5.1. > >>Andi? Zeev? > >> > >>zend_update_static_property_...() make sense and I'll add it. > >> > >>Thanks. Dmitry. > >> > >> > -----Original Message----- > >> > From: Michael Wallner [mailto:mike@php.net] > >> > Sent: Tuesday, August 30, 2005 4:50 PM > >> > To: internals@lists.php.net > >> > Subject: Re: [PHP-DEV] Re: Constants and static methods for > >> > internal classes > >> > > >> > > >> > Hi Dmitry Stogov, you wrote: > >> > > >> > > As I understand the whole patch is OK for you. > >> > > >> > Yep, I still need to test it because your patch is > against HEAD and > >> > I need to port it to PHP_5_1 because my extension is not unicode > >> > aware. My main concern is that it works (of > >> > course) and that it's not to hard for the dev - i.e. me > :) - to use > >> > it. May I suggest to add the usual wrappers like for > >> > zend_update_property()? > >> > > >> > Thanks a lot, > >> > -- > >> > Michael - < mike(@)php.net > > >> > > >> > -- > >> > PHP Internals - PHP Runtime Development Mailing List > >> > To unsubscribe, visit: > >> > http://www.php.net/unsub.php > >> > > >> > > >

Attachment: [application/x-gzip] class_const-5.1.diff.gz
Attachment: [application/x-gzip] class_const-6.diff.gz
Attachment: [application/x-gzip] class_const.tar.gz