Re: change of variable name from tzname to formal_tzname
| From: | Derick Rethans | Date: | Fri, 07 Oct 2005 13:33:57 +0000 |
| Subject: | Re: change of variable name from tzname to formal_tzname | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-19475@lists.php.net to get a copy of this message | ||
Hello,
On Fri, 7 Oct 2005, Kamesh Jayachandran wrote:
> From Yesterday(06/10/2005) onwards NetWare php-5.1 autotests were
> failing because of a segfault from tests/lang/023.phpt which makes one
> mktime call.
> When delved for the cause it seems that In NetWare LibC SDK's time.h
> tzname is expanded to ___tzname() this cause the C preprocessor to
> change the tzname to vague ___tzname function call in
> php_date_parse_tzfile().
> Changing the variable name tzname to formal_tzname or anything more
> pleasing in php_date_parse_tzfile should fix it.
>
> http://puggy.symonds.net/~kameshj/php_date.c.patch
>
> Can you check in this?
Yes, I just committed it.
regards,
Derick
--
Derick Rethans
http://derickrethans.nl | http://ez.no | http://xdebug.org