Re: Re: report of date functions on windows

From: Date: Sun, 16 Oct 2005 19:19:03 +0000
Subject: Re: Re: report of date functions on windows
References: 1 2  Groups: php.internals 
Request: Send a blank email to internals+get-19643@lists.php.net to get a copy of this message
1) timelib_tz_lookup_table defines the gmtoffset as an int, but in the fallback table there are some decimals numbers. So, either remove those entries or change the struct to hold a float. This also applies to the timelib_timezone_id_from_abbr() function, which receives a long, instead of a float.
I committed a slightly modified patch (you should not use any of the US/* mappings f.e.). Thanks. regards, Derick
OK, thanks! And have you decided anything about 1)? May I help in anything? (personally I think that using a float there is a bit overkill in memory usage..) Nuno

« previous php.internals (#19643) next »