The "control-patch" looks okay. But the "warning-fix-patch" really doesn't.
You're actually changing some functions behaviour with some of those
changes. Maybe you didn't notice but there's ldap_get_values() and
ldap_get_values_len() separately. And there's ldap_bind() and ldap_sasl_bind(),
--Jani
On Wed, 9 Nov 2005, Pierangelo Masarati wrote:
On Wed, 2005-11-09 at 00:37 +0200, Jani Taskinen wrote:
I quickly glanced through your patch and if you don't mind,
can you please separate the warning-fixes and functionality patch?
(one patch for fixes, one for adding new stuff :)
It's a bit too much to try and see what was added and what is supposed
to silence some warning.
Sure.
I quickly separated them by editing the patch, so you'll likely get some
fuzz message because of wrong line count. They should apply in any
order, though, because there was no code overlapping. I successfully
did warnings, controls.
Sincerely, p.
Ing. Pierangelo Masarati
Responsabile Open Solution
SysNet s.n.c.
Via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
------------------------------------------
Office: +39.02.23998309
Mobile: +39.333.4963172
Email: pierangelo.masarati@sys-net.it
------------------------------------------