Re: doc comment patch

Hi, I'm not quite sure. Can you send me a patch which includes the shift/reduce conflicts and I'll try and mess around with it? (I'm a bit busy lately so I hope I'll find time quickly). Andi At 06:02 AM 3/21/2003 -0500, Andrei Zmievski wrote:

Andi and Stas, Here is reworked version of doc comment patch. It doesn't store last doc comment in the compiler globals anymore, instead it's returned inside the T_DOC_COMMENT token. I've also modified a couple of rules in the parser to store the doc comment in zend_class_entry and zend_op_array for classes and functions respectively. There is one problem, however, that I need your help with. I tried adding optional_doc_comment to class method declaration but it resulted in a bunch of shift/reduce conflicts. I am not a parser expert, so might you tell me to fix it? The patch is attached.

-Andrei                                       http://www.gravitonic.com/

"Beware of bugs in the above code; I have only proved it correct, not tried it." -- Donald Knuth