Re: Patch for convert_cyr_string()

Hi Antony, Patch looks good, but have you ever thought of using iconv() or mb_convert_encoding() of mbstring extension that comes with Russian charset support? Currently PHP has seven different charset conversion function, namely cyr_convert(), utf8_encode(), utf8_decode(), imap_utf7_encode(), imap_utf7_decode(), iconv(), and mb_convert_encoding() and I'm not a big fan of the idea to add more complexity to those existing functions. That's why I decided to work on the one generic solution. I'll consider borrowing your patch in the ongoing work, but I'm not sure it will actually happen. All I can say for now is "stay tuned".. Regards, Moriyoshi "Antony Dovgal" <tony2001_ru@rambler.ru> wrote: > Good day! > > Derick & Wez said that I should talk to you about this. > I've made a patch, that adds UTF-8 support to convert_cyr_string(); > Diff can be found at > http://tony2001.phpclub.net/convert/diff.txt > (I'll change spaces to tabs and "__" to "_" early). > But Wez said, that you've "plans for a generic charset conversion > facility". > > So, is this patch acceptable? > And what is your plans for conversion facility? > > Thanx in advance, > Antony Dovgal > tony2001@phpclub.net