Re: Filter extension inclusion in core (was: Re: [PHP-DEV] JSON inclusion in core)

On Sat, 21 Jan 2006, Jani Taskinen wrote: > On Fri, 20 Jan 2006, Andi Gutmans wrote: > > Not sure about the functionality, and I agree some of it can probably way, > > but > > Way..wait? :) > > > I would want to finalize the naming before so that we don't have to change > > it and have another BC mode. > > If the naming is the only problem, I can fix that in a minute. > And only thing needing any renaming are these (with my proposal): > > FS_ and FL_ => FILTER_TYPE_ (IMO it's not necessary to separate these) It is, because there's both a sanitizing and validation filter for email and url. > FC_CALLBACK => FILTER_CALLBACK (there's just one) I changed in CVS as follows: FL_* -> FILTER_VLIDATE_* FS_* -> FILTER_SANITIZE_* (except: FS_UNSAFE_RAW to FILTER_UNSAFE_RAW FS_DEFAULT to FILTER_DEFAULT ) FC_CALLBACK -> FILTER_CALLBACK I also commented out the registering of all the FL and FS constants into PHP, as you should use the name of the filter and not this constant. regards, Derick -- Derick Rethans http://derickrethans.nl | http://ez.no | http://xdebug.org