RE: [PHP-DEV] Re: zend_hash.c fishy code
| From: | Stanislav Malyshev | Date: | Mon, 30 Jan 2006 19:02:22 +0000 |
| Subject: | RE: [PHP-DEV] Re: zend_hash.c fishy code | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-21738@lists.php.net to get a copy of this message | ||
JW>> /* rearranged */
JW>> if ((p->h == h) && (p->nKeyLength == nKeyLength)
JW>> && ((nKeyLength == 0) || (!memcmp(p->arKey, arKey, nKeyLength))))
This doesn't seem to be good - there's still a case when p->nKeyLength !=
nKeyLength but the match should happen - when p is 15 (integer) and
incoming key is "15" (string).
--
Stanislav Malyshev, Zend Products Engineer
stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115