Re: Adieu register_globals

On Sun, 5 Mar 2006 16:21:28 +0100 pierre.php@gmail.com (Pierre) wrote: > Hello, > > As discussed last year, register_globals will be removed in php6. This > patch is the first step: > > http://pear.php.net/~pierre/remove_register_globals.txt > > The only thing I find confusing is a comment in main/php_variables.c > php_autoglobal_merge. The comment says something and the tests > something else (register_globals AND instead of register_globals OR). > I will review all the affected tests if you consider this patch ok to > be commited. Some will be updated, other simply removed. > > I did not run benchmarks, but I feel like it speeds up php a bit :) > > Comments and feedbacks welcome, Still welcome... The patch includes now: - the all tests fixes (session) * tests being useless now are skiped (to allow review, will removed later) - functions removed: * session_register * session_unregister * session_is_registered They need register_globals to work I will wait until wednesday for feedbacks or objections, and commit on thursday. --Pierre