Please review: new output control implementation
| From: | Michael Wallner | Date: | Sat, 11 Mar 2006 20:02:08 +0000 |
| Subject: | Please review: new output control implementation | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-22341@lists.php.net to get a copy of this message | ||
Please review my attempt [0] to reimplement the output control code and make
your opinion, support or objections public. A patch [1] to try, the API [2]
and the actual code [3] are online for review. There's alse a README [4]
explaining the what-why-how.
Remaining issues:
- Getting rid of ext/zlib related code in SAPI.c (and elsewhere?) as this
can be handled then from within the output handler. Make the gz handlers
benefit from the new implementation.
- ob_implicit_flush(): In the very original implementation (and in the
documentation) ob_implicit_flush disabled output buffering, but it didn't in
the recent code; restore that functionality?
- Look into solving the bit about xmlrpc errors in main.c.
References:
[0] http://dev.iworks.at/PATCHES/output/
[1] http://dev.iworks.at/PATCHES/output/ob.patch.txt.gz
[2] http://dev.iworks.at/PATCHES/output/php_output.h.txt
[3] http://dev.iworks.at/PATCHES/output/output.c.txt
[4] http://dev.iworks.at/PATCHES/output/README.NEW-OUTPUT-API
Thanks,
--
Michael - <mike(@)php.net> http://dev.iworks.at/ext-http/http-functions.html.gz