Re: PDO, dbh::setDefaultFetchMode patch
| From: | Pierre | Date: | Sat, 18 Mar 2006 23:34:16 +0000 |
| Subject: | Re: PDO, dbh::setDefaultFetchMode patch | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-22523@lists.php.net to get a copy of this message | ||
On 3/19/06, Wez Furlong <kingwez@gmail.com> wrote:
> It breaks the ABI; always add new structure members at the end of
> structures, and always bump the API number when you change anything
> like that in the pdo driver header file.
Ok, not a problem to move it at the end.
> Aside from that, although I personally wouldn't use this patch, it looks OK.
It is for lazy coders like me ;-)
Ilia is fine to add it to 5.x (after 5.1.3), I will commit once 5.1.3
is released, head and to the active 5.x branche.
Thanks for the feedback :)
--Pierre