RE: [PHP-DEV] add_*_vars() speed-up
| From: | Dmitry Stogov | Date: | Mon, 20 Mar 2006 08:30:31 +0000 |
| Subject: | RE: [PHP-DEV] add_*_vars() speed-up | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-22533@lists.php.net to get a copy of this message | ||
Hi Andrey,
But original code probably know nothing about SSL.
Will you patch work with Apache-SSL and Apache-EAPI/mod_ssl?
Will it set HTTPS... variables?
May be I missed, by I didn't see where you patch set AUTH_USER.
But it is not hatrd to check this. :)
Thanks. Dmitry.
> -----Original Message-----
> From: Andrei Zmievski [mailto:andrei@gravitonic.com]
> Sent: Saturday, March 18, 2006 1:20 AM
> To: Dmitry Stogov
> Cc: 'php internals'
> Subject: Re: [PHP-DEV] add_*_vars() speed-up
>
>
> Dmitry,
>
> My patch is almost exactly the same code as the original
> add_common_vars() and add_cgi_vars() functions except that it avoids
> the expensive ap_overlap_tables() call and replaces some
> ap_table_setn
> () calls with ap_table_addn().
>
> -Andrei
>
>
> On Mar 16, 2006, at 11:25 PM, Dmitry Stogov wrote:
>
> > Hi Andrei,
> >
> > I don't see AUTH_USER, HTTPS..., CLIENT_CERT, HTTP_HOST,
> REQUEST_LINE,
> > SERVER_URL.
> >
> > May be not all of them necessary and available in apache, but
> > AUTH_USER,
> > HTTPS are required for PHP.
> >
> > Thanks. Dmitry.
>
>
>