Re: Re: curl_multi_info_read patch review
| From: | Sterling Hughes | Date: | Tue, 02 May 2006 21:36:25 +0000 |
| Subject: | Re: Re: curl_multi_info_read patch review | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-23093@lists.php.net to get a copy of this message | ||
not having tested it, i don't know. this is certainly a RM question,
but if it doesn't break the compile, it does not look like it has the
potential to damage previously existing infrastructure.
-sterling
On 5/2/06, Brian J. France <list@firehawksystems.com> wrote:
PHP_5_1 and head or just head? It could be considered bug fix since curl_multi_info_read was there, but not implemented. Brian On May 2, 2006, at 4:56 PM, Sterling Hughes wrote: please commit it, looks good. thanks, sterling On 5/2/06, Brian J. France <list@firehawksystems.com> wrote:-- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.phpSome guys at work created this patch and have been running with it for a while now. Could I get a few more eyeballs on this? http://www.brianfrance.com/software/php/curl_multi_read.patch Quote from our internal bug: "The attached patch implements curl_multi_info_read(), as well as fixing some memory leak issues and reference problems in the original source." Should I keep it internal or commit it? Thanks, Brian