Re: PHP6 broken
| From: | Hannes Magnusson | Date: | Fri, 09 Jun 2006 15:06:02 +0000 |
| Subject: | Re: PHP6 broken | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24043@lists.php.net to get a copy of this message | ||
On 6/9/06, Dmitry Stogov <dmitry@zend.com> wrote:
Hi Marcus, Could you please fix PHP6 build. You broke it day or two ago :( Yeah, sorry about that, was my fault (it broke 5_2 to).Actually, this bug has been there for a while, but the engine didn't catch it since it had no idea which parameters the methods had. I have a patch ready, which moves all methods from ReflectionFunction into ReflectionFunctionAbstract (except from export, invoke & invokeArgs), http://php.is/bugs/reflection/reflections.patch.txt, just need someone to review it before I commit it. -Hannes
After your modifications of ext/reflection PHP always emits error messages about method incompatibilities. I am not sure if static methods must be checked for compatibility (I mean ReflectionMethod::export()), but ReflectionMethod::invoke() is not static. Thanks. Dmitry. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php