Fwd: SimpleXML Patch
| From: | Michael Gall | Date: | Fri, 14 Jul 2006 03:25:20 +0000 |
| Subject: | Fwd: SimpleXML Patch | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24372@lists.php.net to get a copy of this message | ||
Hi Guys,
I really liked the recent changes that were made to simplexml (addChild),
but I think it needs the capability to add an existing simplexml element as
a child. I've prepared a patch that adds a method (addElement) to do this.
It works, however it causes PHP to segfault on shutdown. I'm not exactly
sure why it's doing this (except that some resource hasn't been incremented
properly). I'm wondering if you could please take a look at the patch (It's
against PHP_5_1) and possibly provide some suggestions as to how to make
this accepted into the tree.
Cheers,
Michael Gall