[PATCH] array_fill_keys
| From: | Matt W | Date: | Fri, 14 Jul 2006 10:36:56 +0000 |
| Subject: | [PATCH] array_fill_keys | ||
| Groups: | php.internals | ||
| Request: | Send a blank email to internals+get-24375@lists.php.net to get a copy of this message | ||
Hi,
Here's a patch to add the array_fill_keys() function instead of extending
array_fill(). I left the bit of cleanup/tweaks I had done to array_fill.
Can someone please review and let me know if anything needs changing?
I have a feeling something will still be wrong it -- works fine, but with
recent code changes, it looks like you're switching to
zend_parse_parameters() where ...get_parameters_ex() had been used. Of
course I used get_parameters, following array_fill. So do I need to change
it, and is that only for MAIN branch? Also wasn't sure if I should mark the
new function "U"nicode compatible.
I'm just going to link to the files instead of attaching. I made simple
tests for array_fill_keys(), but I couldn't add a new file to CVS, so it's a
separate file. I don't have diffs online yet for PHP_5_2 -- wanted to get
these looked at first. :-)
http://realplain.com/php/array_fill_keys.diff
http://realplain.com/php/array_fill_keys.phpt
Thanks if you give this attention,
Matt