Re: [PATCH] array_fill: Allow an array to specify keys
| From: | Matt W | Date: | Sat, 15 Jul 2006 12:45:16 +0000 |
| Subject: | Re: [PATCH] array_fill: Allow an array to specify keys | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-24394@lists.php.net to get a copy of this message | ||
Hi Marcus,
----- Original Message -----
From: "Marcus Boerger"
> Hello Matt,
>
> thanks for the update
>
> best regards
> marcus
No problem, but...
HEAD looks good now (meaning how you guys want it), but there's an issue
with 5.2 -- fill and fill_keys will handle "val" passed by reference
differently. Either fill_keys needs
if (PZVAL_IS_REF(...)) {
SEPARATE_ZVAL(...);
}
added or that part removed from array_fill to make them behave the same,
right? (This is just 5.2, HEAD's fine.)
Also, again, with both branches, if you're allowing array_fill_keys to
return an empty array (which I support), shouldn't array_fill be changed to
do the same?
You want consistency where it's expected, right? :-)
Thanks,
Matt