RE: [PHP-DEV] Re: Long awaited line directive

Can you please send me the latest patch for review? I can't find it for some reason. Thx. Andi > -----Original Message----- > From: Marcus Boerger [mailto:helly@php.net] > Sent: Monday, July 17, 2006 2:34 PM > To: Sara Golemon > Cc: Jeff Moore; internals@lists.php.net > Subject: Re: [PHP-DEV] Re: Long awaited line directive > > Hello Sara, > > Monday, July 17, 2006, 7:09:30 AM, you wrote: > > >>> One minor thought I'd offer up is an option INI setting > to disable > >>> creation of the opcode. This allows the #line directives > to be used > >>> in dev/debug environments without causing an impact for > production > >>> servers during execution. It's not a major performance > hit, but it's something. > >>> > >> Why not leave it up to the user land code generator to include the > >> directive in the debug version or generate without it in the > >> production version? > >> > > Indeed. This suggestion was cross-wired with another > thought when an > > enable/disable switch made more sense. For the sake of > > code-generators it does make more sense to simply not > generate the line during pre-compile. > > That is actually the preferred solution. An additional opcode > does not have any impact on the runtime. So having the ocode > linger around doesn't do anything. Which is the same for > regenerating the code without #line directives. On the > contray adding a new ini setting affects every request so i > guess the answer is quite obvious. > > > Best regards, > Marcus > > -- > PHP Internals - PHP Runtime Development Mailing List To > unsubscribe, visit: http://www.php.net/unsub.php >