Re: Re: cvs: php4(PHP_4_3) /ext/snmp php_snmp.h snmp.c

On Saturday, June 21, 2003, at 11:56 PM, Derick Rethans wrote: > On Sat, 21 Jun 2003, Harrie Hazewinkel wrote: >> harrie Sat Jun 21 17:50:02 2003 EDT >> >> Modified files: (Branch: PHP_4_3) >> /php4/ext/snmp php_snmp.h snmp.c >> Log: >> Applying the contributed patch of Johan hanne. >> The patch enables control on the way the values are returned >> into the PHP script, instaed of always strings. Also the type >> of the value is now returned when configured to do so. >> This enables better management scripts to do more automatic >> processing and value calculations. > > This is a HUGE feature patch... that should definitely NOT go into a > stable branch. I can't believe it. I posted this patch several times. Everybody but Harrie ignored it. I even wrote that I hope it gets into 4.3.3. Nobody except Harrie replied. Now it's applied and NOW somebody has to claim it's a huge feature patch which should not go in. Sorry, but did you actually have a look at the patch? It's NOT a huge feature patch. - It adds the TSRM stuff, but it does it the same way as it's done in the other extensions. - It adds some constants. - It adds two trivial new functions, both only setting or returning a global. - It moves the code for the SNMP value retrieval into a seperate function. But this is more a cleanup than a feature patch...?! The last one is the ONLY thing where existing code is modified, and I've really tested it extensively. So where's the problem??? You could even see it as a BUGFIX patch. The way SNMP values were returned until now was unusable it some situations! I really really need this patch and I have been applying it to each PHP release for more than a year now... Cheers, Jonny