Re: [PATCH] array_count_values bug: mishandling of numbers with leading whitespace

Hi, On 8/13/06, Matt W <php_lists@realplain.com> wrote:

Not reasonable or safe? Then why were the other bugs fixed instead of being marked "Bogus" if array_count_values() was *supposed* to behave differently in 5?

Safe as it will not break working php5 code. Changing this behavior now can break many things out there (for php 5 users, php4 users are out of my worries for this problem). What I mean is that we should first check the impact and see why this change has been done (I remember something like a valid reason, but did not get the time to verify). In short, it is just what I said in the previous discussion, such changes must be done carefully and with a huge amount of test cases (and stick to them). I'm not choosing one solution or another, only saying that the decision should be taken carefully and generally. --Pierre