On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote:
OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt
There might be other issues with virtual_file_ex() that I haven't fully tested.
Can you not simply add the free before the zend_message_dispatcher (ZMSG_FAILED_REQUIRE_FOPEN, Z_STRVAL_P(inc_filename)); line which is followed by a fatal error and in all other instances rely on the existing free() ?
Ilia Alshanetsky
well it depends of the zend api.. If you consider that that error message will be fatal and the include one won't be, well, your solution is simpler, otherwise it needs the bigger patch. Anyway, I agree with you (whoever uses zend engine without PHP will have to have that in attention).
Nuno